floppyrj45/cosma-qc
2
0
Fork 0
Code Issues 2 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

fix(04/04b): load QC_BOTTOM_OK_PCT from thresholds.yaml #9

Open
poulpe wants to merge 2 commits from fix/threshold-yaml-source into feature/auto-pipeline
pull from: fix/threshold-yaml-source
merge into: floppyrj45:feature/auto-pipeline
Conversation 0 Commits 2 Files Changed 4 +83 -2
poulpe commented 2026-05-12 10:36:50 +00:00
Contributor
Copy Link

Root cause: iter-1 patch (thresholds.yaml 50->30) had zero effect. Both stages read env var with hardcoded default=50, ignoring thresholds.yaml.

Fix: _load_bottom_ok_pct() reads thresholds.yaml first, fallback env var, fallback 50.

Sanity: GX019817 (26% bottom_visible) passes with threshold=25%. No regression on done segments.

Root cause: iter-1 patch (thresholds.yaml 50->30) had zero effect. Both stages read env var with hardcoded default=50, ignoring thresholds.yaml. Fix: _load_bottom_ok_pct() reads thresholds.yaml first, fallback env var, fallback 50. Sanity: GX019817 (26% bottom_visible) passes with threshold=25%. No regression on done segments.
poulpe added 1 commit 2026-05-12 10:36:50 +00:00
fix(stages 04/04b): load QC_BOTTOM_OK_PCT from thresholds.yaml (fallback env/hardcoded) 610b3a218b 
Iter-1 patch (thresholds.yaml bottom_visible_pct_min 50→30) had zero effect:
04_frame_extract.py and 04b_trim_water.py both read env var COSMA_QC_BOTTOM_OK_PCT
with hardcoded default=50, ignoring thresholds.yaml entirely.

Add _load_bottom_ok_pct() loader in both stages: reads thresholds.yaml first,
falls back to COSMA_QC_BOTTOM_OK_PCT env var, then hardcoded 50.

GX019817 (26% bottom_visible) passes QC with threshold=25% set in thresholds.yaml.
floppyrj45 added 1 commit 2026-05-12 10:40:00 +00:00
auto-iter 2026-05-12: log iter-3 + veille 2b0c4dc06b
This pull request has changes conflicting with the target branch.
  • pipeline/iteration-log.md
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/threshold-yaml-source:fix/threshold-yaml-source
git checkout fix/threshold-yaml-source
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
backend
backend
deploy
deploy
frontend
frontend
infra
infra
test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-surfer floppyrj45
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: floppyrj45/cosma-qc#9
Delete Branch "fix/threshold-yaml-source"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?